Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] Add the enableCardAfterVerified param to additionalData #3741

Merged
merged 2 commits into from
Jun 25, 2021
Merged

[No QA] Add the enableCardAfterVerified param to additionalData #3741

merged 2 commits into from
Jun 25, 2021

Conversation

marcaaron
Copy link
Contributor

Details

cc @ctkochan22

This should HOLD on https://github.com/Expensify/Auth/pull/5709 to merge + deploy

Fixed Issues

https://github.com/Expensify/Expensify/issues/168429

Tests

  1. Make sure Auth is built with the PR above
  2. Set up a VBA in E.cash
  3. Inspect the additionalData JSON and verify the enableCardAfterVerified param is present

QA Steps

❌

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@marcaaron marcaaron requested a review from a team as a code owner June 24, 2021 01:56
@marcaaron marcaaron self-assigned this Jun 24, 2021
@MelvinBot MelvinBot requested review from MonilBhavsar and removed request for a team June 24, 2021 01:56
@marcaaron marcaaron requested a review from MariaHCD June 24, 2021 01:56
@marcaaron marcaaron changed the title [HOLD] [No QA] Add the enableCardAfterVerified param to additionalData [No QA] Add the enableCardAfterVerified param to additionalData Jun 24, 2021
@marcaaron
Copy link
Contributor Author

Off hold now !

MariaHCD
MariaHCD approved these changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@MariaHCD MariaHCD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM!

Tested locally and the enableCardAfterVerified param is added to the additionalData. However, I did get an error 402 Missing requestorAddressState in additionalData while adding a VBA on e.cash, not sure if that's related to this PR:

Screen Shot 2021-06-25 at 1 55 28 PM

@marcaaron
Copy link
Contributor Author

However, I did get an error 402 Missing requestorAddressState in additionalData while adding a VBA on e.cash, not sure if that's related to this PR

Nice! Seems related to when we added validation, probably we just need to catch and handle this error. Will create a follow up thanks!

@marcaaron marcaaron merged commit b55729a into main Jun 25, 2021
@marcaaron marcaaron deleted the marcaaron-enableCardAfterVerified branch June 25, 2021 15:47
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Jun 25, 2021
Closed
72 tasks
@OSBotify
Copy link
Contributor

🚀 Deployed to staging in version: 1.0.73-4🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production in version: 1.0.74-0🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MariaHCD MariaHCD MariaHCD approved these changes

@MonilBhavsar MonilBhavsar MonilBhavsar approved these changes

Assignees

@marcaaron marcaaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@marcaaron @OSBotify @MariaHCD @MonilBhavsar